[MAGNOLIA-6130] Revisit use case and approach for observing resource changes on classpath Created: 17/Mar/15 Updated: 07/Jun/15 Resolved: 05/Jun/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | configuration, resource-loader |
| Affects Version/s: | None |
| Fix Version/s: | 5.4 |
| Type: | New Feature | Priority: | Blocker |
| Reporter: | Michael Mühlebach | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Config by file / code | ||||||||
| Description |
|
We need to restore classpath observation before going final. This was made a blocker in terms of priority. See comment from May 6 for the status on that. – old description We should revisit and simplify the ClasspathWatcher, in particular:
Additionally, currently we spawn one thread per ClasspathOrigin instance we have, i.e. per YamlConfigurationSource. We should extract ClasspathWatcher and add a ClasspathWatcherService to manage a single thread. |
| Comments |
| Comment by Mikaël Geljić [ 06/May/15 ] |
|
Gave a shot to a so-called ClasspathScanner + service based on the reflections library (same as we use as one-shot in ClasspathOrigin. a. Either we can dramatically reduce the time for checking last-modified date (filtering out the amount of resources to be iterated over) Rephrasing/moving to a standalone issue. |
| Comment by Mikaël Geljić [ 27/May/15 ] |
|
Raised prio to blocker. Two options:
|
| Comment by Magnolia International [ 27/May/15 ] |
|
3rd option:
Option b. is imo a waste of energy, since it'll only add value for definitions we already know about (no add, no delete) Time to check the last-modified dates might be reduced with Additionally, let's not forget there are other issues such as |
| Comment by Philipp Bärfuss [ 27/May/15 ] |
|
The front-end focus lead to the decision to prioritise config by files and for the YAML format. But the new configuration will be used by existing magnolia developers as well. It was also the priority to make configuration easier for everybody. It needs to work and ideally without needing a jrebel license. This is really a blocker for me. |
| Comment by Mikaël Geljić [ 05/Jun/15 ] |
|