[MAGNOLIA-6131] Create new tag called "page" and deprecate "init" Created: 18/Mar/15 Updated: 20/May/15 Resolved: 04/May/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | taglibs, templating |
| Affects Version/s: | None |
| Fix Version/s: | 5.4 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Federico Grilli | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
The [@cms.init /] directive name is misleading. When it was created in Magnolia 4.5 the name actually reflected what the directive did (at least in part) as it injected the GWT-generated js and css which were needed to make page editor work, besides providing info about the preview status, i18n and what not. As of Magnolia 5.0 all it does is actually creating a "cms:page" tag to instruct the page editor about the current content and the page properties dialog id. We should thus deprecate the old cms.init and replace it with a more properly named cms.page directive. |
| Comments |
| Comment by Federico Grilli [ 18/Mar/15 ] |
|
For the release notes/docu |
| Comment by Christopher Zimmermann [ 21/Apr/15 ] |
|
Overall looks good and works in tests. It was nice to remove the unused preview and languageSwitcher items from PageElement. (Now implemented differently with Vaadin) I recommend having the Init* classes extend the Page* classes to eliminate code duplication. Also to consider: InitElementTest & InitBarTagTest. |
| Comment by Federico Grilli [ 04/May/15 ] |
|
Cannot let InitTag extend PageTag as the type parameter expects InitTag as the templating element the tag is operating on |