[MAGNOLIA-6133] Interfaces TemplateDefinition, RenderableDefinition and others in info.magnolia.rendering.template.* are using Boolean and should provide better defaults Created: 19/Mar/15 Updated: 19/May/22 Resolved: 19/May/22 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | rendering |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Philip Mundt | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
Most interfaces (and their implementations) in info.magnolia.rendering.template.* use Boolean rather than the primitive type boolean. When instantiated by Node2Bean, those properties will be null (when no explicitly configured) causing problems all over the place. We should provide better defaults! |
| Comments |
| Comment by Magnolia International [ 19/Mar/15 ] |
|
So we need to have the "defaults" implemented by logic in client code, which probably means we're risking inconsistencies if such an object has different clients. On the top of my head, a couple of long-shot ideas:
|
| Comment by Jan Haderka [ 29/Jul/15 ] |
|
hinting with annotation is interesting, but should be really a "last resort". |
| Comment by Roman Kovařík [ 19/May/22 ] |
|
Hello, This ticket is now marked as closed due to one of the following reasons:
If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you. Thank you, |