[MAGNOLIA-6146] JcrConfigurationSource is lagging behind its Yaml counterpart Created: 26/Mar/15  Updated: 01/Jul/15  Resolved: 30/Jun/15

Status: Closed
Project: Magnolia
Component/s: configuration
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Magnolia International Assignee: Mikaël Geljić
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

JcrConfigurationSource currently does a few things wrong:
Compare info.magnolia.config.source.jcr.JcrConfigurationSource#newProvider with info.magnolia.config.source.yaml.YamlConfigurationSource#loadAndRegister

  • errors are lost instead of being kept in the provider for further inspection
  • metadata is created using information from the bean, which prevents the above (metadata HAS to be there for the definition to be registered)
    • as a consequence we could be accidentally registered an "empty" provider


 Comments   
Comment by Magnolia International [ 30/Jun/15 ]

mgeljic did this with MAGNOLIA-6069 (commit f80cf56)

Generated at Mon Feb 12 04:11:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.