[MAGNOLIA-6154] Revise CE bundle's dependencies Created: 02/Apr/15  Updated: 01/Feb/16  Resolved: 01/Feb/16

Status: Closed
Project: Magnolia
Component/s: bundle
Affects Version/s: 5.4
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLSTK-1490 Remove STK-bundle, refactor STK modul... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Due to the removal of STK from the ce-bundle, some dependencies that were previously pulled in transitively are now not in the bundle anymore.

E.g.

  • public-user-registration
  • form (a requirement for personalization in EE)
  • commenting (no real need, but beneficial for test of sitemesh in EE)
  • ...

Additionally we have to add

<dependency>
  <groupId>info.magnolia.templating</groupId>
  <artifactId>magnolia-templating-essentials-imaging</artifactId>
</dependency>

to the bundle so that the new travel-demo is easily addable to the bundle (simply drop tha jars info.magnolia.demo:magnolia-travel-demo & info.magnolia.demo:magnolia-travel-tours). This dependency is already managed in the parent pom.



 Comments   
Comment by Philip Mundt [ 02/Apr/15 ]

Should we add explicit dependencies for all modules instead of relying on transitive deps.?
We ran into an issue with magnolia-module-legacy-admininterface in tha past (see: https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commitdiff;h=3b0a28f69b225fc70addaee4b836b38e728b1d7f)

Comment by Philip Mundt [ 18/May/15 ]

form module dependency was changed from being scope=provided to scope=compile, so personalization will now "pull in" the module.

Comment by Magnolia International [ 30/Jul/15 ]

Wwe could add them to depMgt to make it easier to get the "right" version for people who do scope:import

Comment by Christian Ringele [ 01/Feb/16 ]

With the new split up of the demo bundles (pro etc.) this issue is resolved.

Generated at Mon Feb 12 04:11:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.