[MAGNOLIA-6157] Allow to configure RestorePreviousVersionCommand using Rule class. Created: 07/Apr/15  Updated: 23/Jun/16  Resolved: 08/Apr/15

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.3
Fix Version/s: 5.3.8

Type: Improvement Priority: Neutral
Reporter: Antonín Juran Assignee: Antonín Juran
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLDAM-654 Assets: restore previous version thro... Closed
relates to MAGNOLIA-6702 Add switch for restoring including de... Closed
dependency
is depended upon by MSHOP-107 Clarify actions available when publis... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Allow to configure RestorePreviousVersionCommand using Rule class. May be needed to restore nodes whose type is not in mgnl: namespace. For example in shop module node types are not from mgnl: namespace, but we want to reuse this command in shop. So it's needed to allow configure custom Rule for collecting node children.



 Comments   
Comment by Antonín Juran [ 08/Apr/15 ]

Add unit test.

Comment by Mikaël Geljić [ 08/Apr/15 ]

Hey,

  1. Any reason we introduced #getRule() / #setRule() on that RestorePreviousVersionCommand, rather than extending RuleBasedCommand which does roughly the same?
  2. Check your code formatting settings
  3. That #restoreChildren() method could use better javadoc, rather than simply saying "does this or that or that", let me come up with something there
Generated at Mon Feb 12 04:11:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.