[MAGNOLIA-6184] Harmonize handling of invisible templates in DefaultTemplateAvailability Created: 27/Apr/15  Updated: 30/Apr/15  Resolved: 28/Apr/15

Status: Closed
Project: Magnolia
Component/s: templating
Affects Version/s: None
Fix Version/s: 5.4

Type: Bug Priority: Neutral
Reporter: Philip Mundt Assignee: Philip Mundt
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PAGES-11 Display a help message if no page tem... Closed
relates to MGNLCAT-156 Make categoryOverview page template i... Closed
relates to MAGNOLIA-6132 Rename ConfiguredTemplateAvailability... Closed
relates to MSITEMESH-31 Make main & decorator page template i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

In 4.5.x and newer versions of Magnolia, page templates are available when visibility=true or when visibility is not set at all. This was changed in the info.magnolia.rendering.template.configured.DefaultTemplateAvailability to be able to display a warning message when no "proper" page templates are available.

This should be changed to be in-sync with previous versions of Magnolia.

Templates considered unworthy should in turn be explicitly set to visibility=false:

  • sitemesh
  • categorization


 Comments   
Comment by Christopher Zimmermann [ 28/Apr/15 ]

pls change name of test
from isNotAvailableForNullVisiblePageTemplate
to isAvailableForNullVisiblePageTemplate

Comment by Philip Mundt [ 30/Apr/15 ]

To QA, e.g.

  • Install EE bundle without STK (with SNAPSHOT versions of categorization & sitemesh)
  • Check that no template is available (by going to page app). A notification should appear.
  • Remove visible property from /modules/categorization/templates/pages/categoryOverview@visible
  • Template should now be available
Comment by Christopher Zimmermann [ 30/Apr/15 ]

Updated comment to reflect that templates without a visible attribute ARE available.

Generated at Mon Feb 12 04:12:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.