[MAGNOLIA-6234] TranslationService could use new ResourceLoader API, thus enabling translations on filesystem etc Created: 29/May/15 Updated: 05/Nov/16 Resolved: 29/Jan/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | i18n, resource-loader |
| Affects Version/s: | 5.4 |
| Fix Version/s: | 5.4.5 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Magnolia International | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.25d | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Epic Link: | Introduction of new i18n | ||||||||||||||||||||||||||||||||||||
| Sprint: | Kromeriz 28 | ||||||||||||||||||||||||||||||||||||
| Story Points: | 1 | ||||||||||||||||||||||||||||||||||||
| Description |
|
In ClasspathOrigin, we currently exclude mgnl-.*, but in fact, info.magnolia.i18nsystem.TranslationServiceImpl and info.magnolia.i18nsystem.DefaultMessageBundlesLoader could likely easily be retrofitted to benefit from the new ResourceLoader/Origin API (and thus be able to load translations from the filesystem or jcr) |
| Comments |
| Comment by Magnolia International [ 16/Sep/15 ] |
|
See PR#20. Not sure which version this should go in. FWIW, DefaultResourceLoader was made package-private, there was no need for this class to be public. Perhaps protected might make more sense. |
| Comment by Roman Kovařík [ 21/Jan/16 ] |
|
For release notes: |
| Comment by Evzen Fochr [ 25/Jan/16 ] |
|
waiting for |
| Comment by Evzen Fochr [ 28/Jan/16 ] |
|
After overriding file in resources app and deleting this hot-fix, i18n file is not reloaded from class-path again. |
| Comment by Evzen Fochr [ 29/Jan/16 ] |
|
Behavior for templates is same, so problem is not in this ticket but elsewhere. |