[MAGNOLIA-6243] Inline rich text links don't work on public instances when using custom URL mappings Created: 04/Jun/15 Updated: 22/Nov/16 Resolved: 23/Sep/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | fckeditor |
| Affects Version/s: | 4.5.24 |
| Fix Version/s: | 4.5.26 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Nils Breunese | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | Support | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d 7h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Sprint: | Kromeriz 11 | ||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||
| Description |
|
We have modified Magnolia's multisite request matcher rules to avoid pages being available on multiple URI's, and to avoid all sites being available on all domains through their prefix. We did this by moving config:/modules/extended-templating-kit/config/rules/uri-starts-with-sitename below its handle-not-empty sibling. Afterwards we found that all of our inline rich text links were broken, because the link URI's are generated (by RepositoryBrowserPage#resolveAbsoluteURI()) and stored in the rich text HTML when the link is created, while assuming the default mappings apply on public instances, which is not necessarily the case. An example from our setup:
An idea might be to have this work like the internal teaser, storing a target UUID and generating the link at render time instead of creation time. Also, we noticed that magnolia-module-fckeditor no longer exists in Magnolia 5, but this mechanism might have been carried over to the new rich text editor? Or is Magnolia 5 handling this differently? |
| Comments |
| Comment by Jan Haderka [ 21/Sep/15 ] |
|
old fckEditor have been replaced by ckEditor. Mechanism is exactly same. The problem you are facing with ckEditor is caused by removal of part of the code that is locating path for the content and trying to determine whether it has shortened url or not. |
| Comment by Milan Divilek [ 22/Sep/15 ] |
|
Reopen: patch is not correct, handle is not added into link when saving dialog second time. 1. Add new URI2RepositoryMapping
2. Go to some page where is "Text and Image" component available. For example to http://localhost:8080/magnoliaAuthor/demo-project/about/history.html ${link:{uuid:{d1b4b57d-3b5d-41ae-85f2-8ed2e4c186ea},repository:{website},handle:{/demo-project/about/subsection-articles/article},nodeData:{},extension:{html}}}
4. Open dialog and save it again ${link:{uuid:{},repository:{website},handle:{/},nodeData:{},extension:{html}}
|