[MAGNOLIA-6263] Locale is always set to fallback locale on requests where VirtualURIFilter is run Created: 22/Jun/15  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.4
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLDEMO-66 Tour page only displays english Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

So, VirtualURIFilter cannot be used on multilanguage sites.
The locale is set on the aggregationstate by the I18nContentSupportFilter, it is determined by the active I18nContentSupport. When DefaultI18nContentSupport is used, it determines the locale from the aggregationState currentURI. (A benefit of the currentURI is that it already has the site removed from the uri)

If a VirtualURIFilter matches the request, it can perform a forward.

This will cause the filter chain to be run again but this time when I18nContentSupport is hit, the URI no longer contains the locale, so the fallback locale will be set on the aggregation state.

So the problem is that I18nContentSupport gets run twice on the request, but it is only designed to be run once.

See related ticket for example.



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 04:12:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.