[MAGNOLIA-6294] maxComponents are not working from area definition Created: 10/Jul/15 Updated: 21/Jul/15 Resolved: 21/Jul/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | templating |
| Affects Version/s: | 5.3.9 |
| Fix Version/s: | 5.3.11, 5.4.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Tomáš Gregovský | Assignee: | Sang Ngo Huu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d | ||
| Original Estimate: | 0.75d | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Sprint: | Sprint 1 (Vietnam), Sprint 2 (Basel) |
| Story Points: | 1 |
| Description |
[@cms.area name="cols" maxComponents=2 /] is not working, maxComponent is not supported parameter. will appreciate if this can go to product as soon as possible |
| Comments |
| Comment by Jan Haderka [ 10/Jul/15 ] |
|
Patch for problem in question. |
| Comment by Sang Ngo Huu [ 17/Jul/15 ] |
|
Code is checked in to branch I saw in 5.4.x don't have the fixed too, Please let me know if it should be port to 5.4.x |
| Comment by Federico Grilli [ 20/Jul/15 ] |
|
sang.ngo yes, once fixed please port it to 5.4.x too. Thanks. |
| Comment by Federico Grilli [ 20/Jul/15 ] |
|
Please move protected Integer integer(Map<String, TemplateModel> params, String key, Integer defaultValue) to AbstractDirective |
| Comment by Sang Ngo Huu [ 21/Jul/15 ] |
|
The review is fixed, Cloned to MAGNOLIA-6311 for tracking. Code for 5.4.x is committed to MAGNOLIA-6311 branch. MAGNOLIA-6311 should be deleted after intergrating successfully. |