[MAGNOLIA-6365] Unclosed sessions on JcrResourceOrigin#onEvent failures Created: 08/Sep/15  Updated: 15/Apr/16  Resolved: 07/Oct/15

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Evzen Fochr Assignee: Evzen Fochr
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1.5h
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-6333 java.nio.file.InvalidPathException du... Closed
relation
is related to MGNLOBS-36 Unclosed sessions on CommandEventList... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 14
Story Points: 2

 Description   

When JcrResourceOrigin#onEvent fails during the execution, sessions are not closed properly resulting in errors in log files like:

2015-08-03 16:16:53,295 WARN  org.apache.jackrabbit.core.SessionImpl            : Unclosed session detected. The session was opened here:
java.lang.Exception: Stack Trace
        at org.apache.jackrabbit.core.SessionImpl.<init>(SessionImpl.java:222)
        at org.apache.jackrabbit.core.SessionImpl.<init>(SessionImpl.java:239)
        at org.apache.jackrabbit.core.XASessionImpl.<init>(XASessionImpl.java:101)
        at org.apache.jackrabbit.core.RepositoryImpl.createSessionInstance(RepositoryImpl.java:1613)
        at org.apache.jackrabbit.core.RepositoryImpl.createSession(RepositoryImpl.java:956)
        at org.apache.jackrabbit.core.RepositoryImpl.login(RepositoryImpl.java:1501)
        at org.apache.jackrabbit.core.jndi.BindableRepository.login(BindableRepository.java:162)
        at info.magnolia.jackrabbit.ProviderImpl.getSystemSession(ProviderImpl.java:501)
        at info.magnolia.repository.DefaultRepositoryManager.getSystemSession(DefaultRepositoryManager.java:298)
        at info.magnolia.context.SystemRepositoryStrategy.internalGetSession(SystemRepositoryStrategy.java:54)
        at info.magnolia.context.AbstractRepositoryStrategy.getSession(AbstractRepositoryStrategy.java:75)
        at info.magnolia.context.AbstractContext.getJCRSession(AbstractContext.java:132)
        at info.magnolia.resourceloader.jcr.JcrResourceOrigin.getJcrSession(JcrResourceOrigin.java:258)
        at info.magnolia.resourceloader.jcr.JcrResourceOrigin.getNode(JcrResourceOrigin.java:247)
        at info.magnolia.resourceloader.jcr.JcrResourceOrigin.access$300(JcrResourceOrigin.java:87)
        at info.magnolia.resourceloader.jcr.JcrResourceOrigin$1.onEvent(JcrResourceOrigin.java:322)
        at info.magnolia.cms.util.ObservationUtil$ObservationBasedDelayedExecutor$1.run(ObservationUtil.java:253)
        at info.magnolia.cms.util.DelayedExecutor$RunnableWrapper.run(DelayedExecutor.java:103)
        at EDU.oswego.cs.dl.util.concurrent.ClockDaemon$RunLoop.run(Unknown Source)
        at java.lang.Thread.run(Thread.java:745)


 Comments   
Comment by Evzen Fochr [ 10/Sep/15 ]

For future assignee see https://scm.magnolia-cms.com/projects/MAGNOLIA/repos/main/pull-requests/12/overview

Comment by Mikaël Geljić [ 06/Oct/15 ]

These "Unclosed session detected" warnings are typically a consequence of another failure (here MAGNOLIA-6333).
It actually doesn't cause any major system issue, as Jackrabbit detects those unclosed sessions for us, and releases them himself (see SessionImpl#finalize()).

As such, there's nothing more meaningful we can do, so this is deemed "not an issue", and will be closed as soon as MAGNOLIA-6333 is completed.

Generated at Mon Feb 12 04:13:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.