[MAGNOLIA-6377] Ignore (un)translated items when no I18nKeyGenerator is specified and no configured key exists Created: 16/Sep/15 Updated: 02/May/16 Resolved: 26/Apr/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | i18n |
| Affects Version/s: | 5.3 |
| Fix Version/s: | 5.4.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Magnolia International | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Sprint: | Kromeriz 41 |
| Story Points: | 1 |
| Description |
|
If a component is marked with @I18nable, but no I18nKeyGenerator is specified, NullKeyGenerator is used. This returns the "configured" value (e.g whatever the getters with @I18nText return). If those values are not configured (yet), this results in NPEs down the line, because TranslationServiceImpl tries to lookup null in the translation bundles. |
| Comments |
| Comment by Magnolia International [ 16/Sep/15 ] |
|
See PR#20, solved this with |
| Comment by Roman Kovařík [ 26/Apr/16 ] |
|
PR#20 was declined and this ticket is done in a separate PR. |