[MAGNOLIA-6392] Missing resourcesRoot parameter in Magnolia 5.4 ResourcesServlet Created: 25/Sep/15  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.4, 5.4.1, 5.4.2
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Gerton ten Ham Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Java Source File StaticResourcesServlet.java    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Looking into the new servlet mapped to /.resources (info.magnolia.module.resources.ResourcesServlet) i noticed that it is not using the servlet parameter "resourcesRoot" like was in info.magnolia.cms.servlets.ClasspathSpool.

I really would like to have this parameter re-introduced again as it provides a way to "hide" resources from the public by simply adding a path which contains the resources you would like to expose through this servlet.

This is IMO a better approach then provide a blacklisting using a forbidden resource pattern.

If this is to much trouble then please make sure that in info.magnolia.module.resources.ResourcesServlet:

  • the linker property can be used using a public getter
  • all protected methods are made public

This way i can use my own servlet with a resourcesPath which extends the ResourcesServlet as much as possible instead that i have to copy all code.



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 04:14:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.