[MAGNOLIA-6453] DefaultMessageBundlesLoader: align log messages and javadocs with its business logic Created: 04/Dec/15  Updated: 09/Mar/16  Resolved: 07/Mar/16

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 5.3.15

Type: Bug Priority: Neutral
Reporter: Zdenek Skodik Assignee: Antonín Juran
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6241 The messages are not replaced by new ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 28, Kromeriz 34
Story Points: 1

 Description   

In order to prevent unnecessary confusions.



 Comments   
Comment by Roman Kovařík [ 21/Jan/16 ]

Only for 5.3.x. 5.4.x will provide file system and JCR translations, see MAGNOLIA-6234.

Comment by Antonín Juran [ 26/Jan/16 ]

Already fixed by MAGNOLIA-5891

Comment by Zdenek Skodik [ 18/Feb/16 ]

ajuran imho the class still does something different than it claims, e.g.:

Moreover, should an existing properties file already contains keys found in the one currently being loaded, the method will output a WARN message and will overwrite the existing key with the new one.

while we load the new and existing ones:

final Properties properties = new Properties();
properties.load(inStream);
Properties existingProperties = messages.get(locale);

to replace all shares the properties hashtable had with the ones that has been loaded beforehand and kept at existingProperties.

properties.putAll(existingProperties);

The related debug message could also be improved along by. btw the related support ticket has been reported for 5.3.12, while MAGNOLIA-5891 was fixed for 5.3.4.

Comment by Antonín Juran [ 04/Mar/16 ]

zdenekskodik I'll fix it.

Comment by Zdenek Skodik [ 04/Mar/16 ]

go ajuran go

Generated at Mon Feb 12 04:14:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.