[MAGNOLIA-6521] Module config via Light Module Created: 28/Jan/16 Updated: 14/Oct/21 Resolved: 31/Jan/19 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 5h 49m | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Documentation update required: |
Yes
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Epic Link: | LD Backlog | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Foundation 3, Foundation 4, Foundation 5 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
A light module should be able to supply the configuration which is typically stored in the "config" folder directly under a modules configuration in the config app. For example: This could possibly be implemented so: the module descriptor can also specify the configuration that is typically supplied by JCR in the /modules/modulename/config node. Additionally, a 2nd module must be able to decorate this configuration via yaml files that it provides. |
| Comments |
| Comment by Jan Haderka [ 09/Feb/16 ] |
|
Decoration - yes. |
| Comment by Christopher Zimmermann [ 17/Feb/16 ] |
|
Light modules will be able to supply groovy classes. |
| Comment by Roman Kovařík [ 17/Jan/19 ] |
|
There is already a working PoC for this, see |
| Comment by Hieu Nguyen Duc [ 21/Feb/19 ] |
|
QAed on "magnolia-enterprise-pro-demo-bundle-6.0.1-20190220.091844-362-tomcat-bundle.zip".
Case 1: + Start the instance + Put config.yaml + The value is applied correctly in M5's DAM app but Definitions app doesn't show the correct new value => Definitions app issue or file resource shouldn't override JCR resource?
Case 2: (continue from case1) + Delete JCR node "/modules/dam-app/config" + Restart the instance => DAM app and Definitions app show correctly
Case 3: (continue from case2) + Put _config.yaml => DAM app and Definitions app show correctly
|
| Comment by Roman Kovařík [ 17/Apr/19 ] |
This follow decoration pattern for any registry so both version would work, see
More precisely: "it's not possible to add a new module at runtime".
|