[MAGNOLIA-6538] Improve support IoC multi-binding Created: 09/Feb/16 Updated: 26/Jun/19 |
|
| Status: | Accepted |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.4.4 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | guice, ioc, multibining | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
Guice multi-binding support introduced in Magnolia 5.4 is a useful mechanism which allows to resolve various configured components of the similar origin as a single set. To make it even more elegant - we have introduced a @Multibinding annotation which our IoC integration recognises and prepares according bindings. However, the support for multi-binding so far spans only the case of interface/implementation mappings. If one binds an interface to a javax.inject.Provider or a singleton instance - @Multibinding annotation isn't respected (we simply don't look for it). |
| Comments |
| Comment by Michael Mühlebach [ 10/Feb/17 ] |
|
We do not need it atm but it causes an inconsistency which will cause an issue in the future. So to remove technical debt we should solve it. |