[MAGNOLIA-6582] Convert DataTransporter to dependency injection Created: 04/Mar/16 Updated: 04/Mar/19 Resolved: 30/Aug/17 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 5.4 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Nickolaus Wing | Assignee: | Unassigned |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Date of First Response: | |||||
| Description |
|
We discovered long ago that the export command writes to a file, then reads that file back before streaming the final xml data to the client. This results in 1) system-wide performance degradation during large exports, and 2) occasional failed-to-delete files left on the disk, eventually filling it. When we were on Magnolia 4.5, we were building the entire project, including magnolia-core, so I had a local change to DataTransporter.java that did away with the "format" and "keepversionhistory" options, so that writing to file was unnecessary. Exports were faster, the system was faster, the drive didn't fill up. Now that we're on 5.4.4, we no longer build the core project, so I'm looking for a way to do something similar to what we had before, but coming up empty. DataTransporter is not dependency-injected, so I can't simply override it (to the best of my knowledge). I don't know whether doing away with the whole writing to file strategy is right for everyone, so maybe the easiest thing to do to put the power in my hands is to make DataTransporter a dependency injected singleton instead of a static class? |
| Comments |
| Comment by Richard Gange [ 30/Aug/17 ] |
|
Replaced by info.magnolia.jcr.util.PropertiesImportExport |