[MAGNOLIA-6675] ContentTypeFilter should warn if content type is not set Created: 20/May/16 Updated: 30/Nov/16 Resolved: 13/Jul/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 5.3.13, 5.4 |
| Fix Version/s: | 5.3.16, 5.4.8 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Patrick Lötscher | Assignee: | Antonín Juran |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | devwl, support | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.25h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Sprint: | Kromeriz 52 | ||||||||||||
| Story Points: | 5 | ||||||||||||
| Description |
|
The ContentTypeFilter sets a default ContentType on the response if no ContentType is set. This is done after calling the filter chain when the response can already be commited and therefore it has no effect. |
| Comments |
| Comment by Roman Kovařík [ 07/Jul/16 ] |
|
Reopened: we now check the status code and if it's 200, than we check if a content type is set. This makes changes in virtual URI filter redundant. Check also the validity of changes in the login filter. |