[MAGNOLIA-6677] Remove FTL 5sec cache in Developer mode Created: 23/May/16 Updated: 09/Feb/17 Resolved: 11/Jun/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.4.6 |
| Fix Version/s: | 5.4.8, 5.5 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Christopher Zimmermann | Assignee: | Ilgun Ilgun |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||
| Documentation update required: |
Yes
|
||||||||||||||||||||
| Epic Link: | LD: Fundamental features | ||||||||||||||||||||
| Sprint: | Basel 48 | ||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||
| Description |
|
Currently FTL files are cached for 5 seconds when they are requested. In developer mode this should be removed to improve developer experience of the responsiveness of Magnolia to their changes. This will also enable using a "hot browser reload" mechanism like BrowserSync or LiveReload. Symptom: Notes: The 'FTL lock' problem is solvable by doing this at L123 in FreemarkerHelper: cfg.setTemplateUpdateDelay(0); As this change will negatively impact performance, it should only be appllied when developer mode is enabled. Documentation: |
| Comments |
| Comment by Christopher Zimmermann [ 23/May/16 ] |
|
See reason that this line was commented out in https://jira.magnolia-cms.com/browse/MAGNOLIA-1482 If we reinstate the check (which we could), serving templates will take performance impact (at all sources - classpath, JCR and file system). We could of course do that, but I would maybe suggest to do so by default only on author instance and not on public where changes in templates should be much less frequent and performance is much more critical. |