[MAGNOLIA-6685] Buffer YAML file mod checks Created: 02/Jun/16 Updated: 09/Sep/16 Resolved: 09/Jun/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Sprint: | Basel 47 | ||||||||||||||||
| Story Points: | 2 | ||||||||||||||||
| Description |
|
During a page rendering sequence we experience numerous DefinitionProvider#get() calls which for the case of YamlDefinitionProvider lead to the last modification date checks for all of the involved files. This adds a tiny performance overhead per call which stacks up into a big one and also is prone to exceed the open file descriptor quota. Solution here is to perform the last modification checks not more often that 1 per a second (in a normal development case - this is negligible from the dev experience point of view). |