[MAGNOLIA-6724] TranslationService should not throw ProvisionException when i18nModule is not ready Created: 19/Jul/16  Updated: 09/Feb/17  Resolved: 22/Jul/16

Status: Closed
Project: Magnolia
Component/s: i18n
Affects Version/s: 5.4.7
Fix Version/s: 5.4.8, 5.5

Type: Bug Priority: Neutral
Reporter: Ilgun Ilgun Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: i18n
Remaining Estimate: 0d
Time Spent: 3h
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6725 DefaultMessageBundlesLoader is always... Closed
causality
caused by MAGNOLIA-6471 Tooling for i18n Closed
relation
is related to MGNLGROOVY-143 Rescue app is broken due to i18n not ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 53
Story Points: 2

 Description   

Currently we have a mechanism which we inform users for missing translations if the debug mode (i18n) is on. However, TranslationService is throwing ProvisionException(s) if i18n module is not ready. We have a valid case where i18n module is not ready but we might get the translations from TranslationService directly.

Solution

Catching the given exceptions and simply assuming the debug mode is off when i18n module is not ready.



 Comments   
Comment by Roman Kovařík [ 22/Jul/16 ]

Reopened:

  • Missing dependency on i18n 5.4.8+
    OR
  • I was also wondering why we don't create translation service manually instead of getting it from component so we can provide a dummy i18n module provider and we don't have to have that ugly exception catch in i18n.
Comment by Ilgun Ilgun [ 22/Jul/16 ]

Which dependency is missing?

I am wondering where do you want to create a translation service manually?

Comment by Roman Kovařík [ 22/Jul/16 ]

Sorry, this belongs to the groovy ticket, moving the comment and closing again.

Comment by Philip Mundt [ 22/Jul/16 ]
  • Missing dependency on i18n 5.4.8+
  • I was also wondering why we don't create translation service manually instead of getting it from component so we can provide a dummy i18n module provider and we don't have to have that ugly exception catch in i18n.
  1. This is IN the i18n module. There is nothing to add.
  2. I vote for component only.
Generated at Mon Feb 12 04:17:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.