[MAGNOLIA-6734] Assess and clean up redundant system context executions Created: 02/Aug/16  Updated: 03/Oct/16  Resolved: 05/Aug/16

Status: Closed
Project: Magnolia
Component/s: security
Affects Version/s: 5.5
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: audit, logging, system-context
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-6686 System context operations hide the re... Closed
duplicate
duplicates MAGNOLIA-6731 Some operations are requested to run ... Accepted
duplicates MAGNOLIA-6798 Reduce log level from warn to debug u... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

With MAGNOLIA-6686, we now prevent re-wrapping current context within system context, if it is already a system context.

While doing so, we added some warnings to show where we actually run into this. This has become pretty verbose already, as shown on the bundle builds for example.

Now we need to look at such warnings and assess if we can remove redundant wrappings in sys-ctx, or if the warning is too harsh.

Below is a trace example provided by oanh.thai, just when assigning a task to herself in the pulse—in this particular case, it points to the GroupManager, but we should question if the extra wrapping comes from here or from the UI, i.e. rather keep the system-context encapsulation on the lower level components (which might be consumed from different ends), and get rid of the UI one.

2016-08-01 18:39:05,839 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.jcr.wrapper.MgnlPropertySettingContentDecorator$ChangeLastUpdateDateOp:info.magnolia.jcr.wrapper.MgnlPropertySettingContentDecorator$ChangeLastUpdateDateOp@387a784d in system context while already in system context.
(...) [16 more invocations via content-decorators ops]
2016-08-01 18:39:05,848 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.jcr.wrapper.MgnlPropertySettingContentDecorator$ChangeLastUpdateDateOp:info.magnolia.jcr.wrapper.MgnlPropertySettingContentDecorator$ChangeLastUpdateDateOp@26a4d9d6 in system context while already in system context.
2016-08-01 18:39:05,862 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.cms.security.MgnlGroupManager$4:get direct sub groups publishers in system context while already in system context.
2016-08-01 18:39:05,863 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.cms.security.MgnlGroupManager$4:get direct sub groups demo-project-publishers in system context while already in system context.
2016-08-01 18:39:05,865 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.cms.security.MgnlGroupManager$4:get direct sub groups publishers in system context while already in system context.
2016-08-01 18:39:05,865 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.cms.security.MgnlGroupManager$4:get direct sub groups demo-project-publishers in system context while already in system context.
2016-08-01 18:39:05,868 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.cms.security.MgnlGroupManager$4:get direct sub groups publishers in system context while already in system context.
2016-08-01 18:39:05,868 WARN  info.magnolia.context.MgnlContext                 : Requested to run info.magnolia.cms.security.MgnlGroupManager$4:get direct sub groups demo-project-publishers in system context while already in system context.


 Comments   
Comment by Mikaël Geljić [ 05/Aug/16 ]

Found duplicate, keeping that one as additional reference.

Generated at Mon Feb 12 04:17:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.