[MAGNOLIA-6736] Expose Map2Bean conversion errors via DefinitionProvider interface Created: 03/Aug/16 Updated: 09/Feb/17 Resolved: 01/Sep/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.4.7 |
| Fix Version/s: | 5.5 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Epic Link: | Definitions app | ||||||||||||||||||||||||
| Sprint: | Basel 59 | ||||||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||||||
| Description |
|
Improve DefinitionProvider#getErrorMessages() API with respect to the fact that M2B now returns more sophisticated Problem objects. Collect problems from conversion result produced by M2B (in YamlDefinitionProvider#resolve). Also provide fallback support for the old API. At the same time we should adjust the validity criteria of a definition provider: currently DefinitionProviderBuilder.DefinitionProviderImpl#DefinitionProviderImpl() assumes any error message makes provider invalid, but we could encounter also just a warning => I suggest to iterate over the newly introduced problems and check their types searching for the the most severe ones. |