[MAGNOLIA-6767] Update org.apache.httpcomponents:httpclient to version 4.5.2 Created: 29/Aug/16 Updated: 09/Feb/17 Resolved: 09/Sep/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.5 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Ilgun Ilgun | Assignee: | Ilgun Ilgun |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 20m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Sprint: | Basel 61 | ||||||||||||||||||||
| Story Points: | 0 | ||||||||||||||||||||
| Description |
|
This might lead into problems such as the following regression: https://issues.apache.org/jira/browse/HTTPCLIENT-1746. This ticket should cover them all and add unit tests. java.lang.NullPointerException org.apache.http.client.utils.URLEncodedUtils.parse(URLEncodedUtils.java:235) info.magnolia.cms.security.auth.login.FormLogin.requiresRedirect(FormLogin.java:111) info.magnolia.cms.security.auth.login.FormLogin.handle(FormLogin.java:87) info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:71) info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:81) info.magnolia.cms.filters.CosMultipartRequestFilter.doFilter(CosMultipartRequestFilter.java:87) info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:59) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79) info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:155) info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79) info.magnolia.cms.filters.ContextFilter.doFilter(ContextFilter.java:128) info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79) info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:65) info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85) info.magnolia.cms.filters.SafeDestroyMgnlFilterWrapper.doFilter(SafeDestroyMgnlFilterWrapper.java:107) info.magnolia.cms.filters.MgnlFilterDispatcher.doDispatch(MgnlFilterDispatcher.java:67) info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:108) info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:94) |
| Comments |
| Comment by Philip Mundt [ 30/Aug/16 ] |
|
We should go to the latest and greatest version! |
| Comment by Philip Mundt [ 02/Sep/16 ] |
|
Reopening due to issue dowstream. CE Bundle has failing test due to newly managed dep of org.apache.httpcomponents:httpmime:jar:4.5.2 which doesn't have method needed by net.sourceforge.htmlunit:htmlunit:jar:2.15:
java.lang.NoSuchMethodError: org.apache.http.entity.ContentType.create(Ljava/lang/String;[Lorg/apache/http/NameValuePair;)Lorg/apache/http/entity/ContentType;
at org.apache.http.entity.mime.MultipartEntityBuilder.buildEntity(MultipartEntityBuilder.java:219)
at org.apache.http.entity.mime.MultipartEntityBuilder.build(MultipartEntityBuilder.java:240)
at com.gargoylesoftware.htmlunit.HttpWebConnection.makeHttpMethod(HttpWebConnection.java:321)
at com.gargoylesoftware.htmlunit.HttpWebConnection.getResponse(HttpWebConnection.java:166)
at com.gargoylesoftware.htmlunit.util.DebuggingWebConnection.getResponse(DebuggingWebConnection.java:111)
at com.gargoylesoftware.htmlunit.WebClient.loadWebResponseFromWebConnection(WebClient.java:1313)
at com.gargoylesoftware.htmlunit.WebClient.loadWebResponse(WebClient.java:1230)
at com.gargoylesoftware.htmlunit.WebClient.download(WebClient.java:2014)
at com.gargoylesoftware.htmlunit.html.HtmlForm.submit(HtmlForm.java:140)
at com.gargoylesoftware.htmlunit.html.HtmlSubmitInput.doClickStateUpdate(HtmlSubmitInput.java:99)
at com.gargoylesoftware.htmlunit.html.HtmlElement.click(HtmlElement.java:1321)
at com.gargoylesoftware.htmlunit.html.HtmlElement.click(HtmlElement.java:1268)
at com.gargoylesoftware.htmlunit.html.HtmlElement.click(HtmlElement.java:1216)
at info.magnolia.integrationtests.ServletSanityTest.testMultipartFilter(ServletSanityTest.java:78)
This issue is tigtly related to Reverted commit. |