[MAGNOLIA-6812] Update org.apache.commons:commons-lang3 to version 3.4 Created: 28/Jun/16  Updated: 09/Feb/17  Resolved: 30/Aug/16

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.5
Fix Version/s: 5.5

Type: Story Priority: Neutral
Reporter: Maxime Michel Assignee: Cedric Reichenbach
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 3d
Original Estimate: Not Specified

Attachments: PNG File commons.png    
Issue Links:
Relates
relates to MGNLCAS-23 Import dependency management from mag... Closed
relates to MGNLTPLSMPL-24 Import dependency management from mag... Closed
relates to MGNLCACHE-140 Update org.apache.commons:commons-lan... Closed
relates to MGNLCDEP-93 Update org.apache.commons:commons-lan... Closed
relates to MGNLCTS-82 Update org.apache.commons:commons-lan... Closed
relates to MGNLDIFF-94 Import dependency management from mag... Closed
relates to MGNLEE-453 Update org.apache.commons:commons-lan... Closed
relates to MGNLGA-21 Import dependency management from mag... Closed
relates to MGNLGROOVY-150 Import dependency management from mag... Closed
relates to MGNLGS-126 Update org.apache.commons:commons-lan... Closed
relates to MGNLIMG-188 Update org.apache.commons:commons-lan... Closed
relates to MGNLNEWSLETTER-51 Import dependency management from mag... Closed
relates to MGNLRESTCL-21 Import dependency management from ma... Closed
relates to MGNLSLOCK-40 Import dependency management from mag... Closed
relates to MGNLTOOLS-82 Update org.apache.commons:commons-lan... Closed
relates to MGNLWEBDAV-49 Update org.apache.commons:commons-lan... Closed
relates to MGNLXAA-99 Update org.apache.commons:commons-lan... Closed
relates to MAGNOLIA-6750 Update org.apache.commons:commons-lan... Closed
relates to MGNLACTIVATION-133 Update org.apache.commons:commons-lan... Closed
relates to MGNLADVCACHE-75 Update org.apache.commons:commons-la... Closed
relates to MGNLCAT-169 Update org.apache.commons:commons-lan... Closed
relates to MGNLCMNT-123 Import dependency management from mag... Closed
relates to MGNLDAM-668 Import dependency management from mag... Closed
relates to MGNLDATA-272 Update org.apache.commons:commons-lan... Closed
relates to MGNLDEMO-179 Import dependency management from mag... Closed
relates to PAGES-85 Update org.apache.commons:commons-lan... Closed
dependency
depends upon MGNLCE-54 Update org.apache.commons:commons-lan... Closed
depends upon MGNLLDAP-93 Import dependency management from mag... Closed
relation
is related to LOGTOOLS-20 Import dependency management from mag... Closed
is related to JCRTOOLS-37 Import dependency management from mag... Closed
is related to MGNLBACKUP-103 Update org.apache.commons:commons-lan... Closed
is related to MGNLOBS-38 Import dependency management from mag... Closed
is related to MGNLPN-318 Update org.apache.commons:commons-lan... Closed
is related to MGNLPUR-169 Update org.apache.commons:commons-lan... Closed
is related to MGNLREST-72 Import dependency management from mag... Closed
is related to MGNLSITE-70 Import dependency management from mag... Closed
is related to MGNLUI-3987 Update commons-lang3 and use magnolia... Closed
is related to MGNLWORKFLOW-337 Update org.apache.commons:commons-lan... Closed
is related to MSITEMESH-44 Update org.apache.commons:commons-lan... Closed
is related to MTE-90 Import dependency management from mag... Closed
is related to MULTISITE-66 Import dependency management from mag... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Update 3rd-party libraries for 5.5
Sprint: Basel 59
Story Points: 13

 Description   

As part of the libraries update done with 5.5, update org.apache.commons libraries we use to the following versions:

org.apache.commons:commons-lang3 .......................... 3.1 -> 3.4

Changelogs:
https://commons.apache.org/proper/commons-lang/release-notes/RELEASE-NOTES-3.4.txt
https://commons.apache.org/proper/commons-lang/release-notes/RELEASE-NOTES-3.3.txt
https://commons.apache.org/proper/commons-lang/release-notes/RELEASE-NOTES-3.2.txt



 Comments   
Comment by Philip Mundt [ 07/Jul/16 ]

Current community-webapp – built by debug branches – contain multiple version of above libraries, see:

All modules with these dependencies either need to import the dependencyManagement section of the main project or also need to be update. See epic MAGNOLIA-5888.

Comment by Philip Mundt [ 07/Jul/16 ]

After a discussion with mgeljic we came to the conclusion that

  1. We need an overview (the delta) of the changelog(s) of the libs of this update
  2. Most likely we want to import the dependency management section of main project in the modules that specify the versions themselves (see MAGNOLIA-5888)
    • We have a lot of modules that have two different baseline version – used in 5.5 and 5.4.x – thus they'll have to handle two different versions of above libs
Comment by Jan Haderka [ 07/Jul/16 ]

Also:

  • each of the commons lib updates should be considered independently and done in separate subtask or issue linked to this one.
  • commons lib updates should done as last of the updates we do since quite few of their versions can be forced by other dependency updates, e.g. jackrabbit.
Comment by Zdenek Skodik [ 16/Aug/16 ]

Could we include httpclient as well? MGNLUI-3984

Comment by Philip Mundt [ 16/Aug/16 ]

We'll split all of them into subtasks, as some require more adjustment as others (e.g. lang3 code adjustments were done previously, collections4 not).

Comment by Zdenek Skodik [ 16/Aug/16 ]

You know I'm asking since you guys reference just 3 libs out of the entire family, the guy at MGNLUI-3894 tested it slightly, and yeah they broke the API again, which is a bit sensitive in that case since you can't login via POST with our default login form then.

Comment by Cedric Reichenbach [ 30/Aug/16 ]

Checked dependency tree over whole ee-packs project: There are no depencencies to older commons-lang(3) versions left except one introduced by the dying legacy-admininterface module.

Generated at Mon Feb 12 04:18:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.