[MAGNOLIA-6822] Fix a couple of visual design issues on the new installation screen Created: 18/Oct/16  Updated: 02/Nov/16  Resolved: 01/Nov/16

Status: Closed
Project: Magnolia
Component/s: installation
Affects Version/s: None
Fix Version/s: 5.5

Type: Bug Priority: Major
Reporter: Ngoc Nguyenthanh Assignee: Michal Novak
Resolution: Fixed Votes: 0
Labels: visual-design
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File License 160px from left.png     PNG File Windows8_IE11_footer.png     PNG File Windows8_IE11_installation-inProgress.png     PNG File Windows8_IE11_installation.png     PNG File Windows8_IE11_license.png     PNG File license-alignment.png     PNG File message-hover-alignment.png     PNG File right-alignment.png     PNG File show_all_details.png    
Issue Links:
Cloners
is cloned by MGNLCE-63 Fix a couple of visual design issues ... Closed
is cloned by MGNLEE-467 Fix a couple of visual design issues ... Closed
relation
is related to MGNLEE-428 Redesign installation screens Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Fresh installation screen
Sprint: Kromeriz 68
Story Points: 1

 Description   

There's a couple of visual design issues that have to be fixed on the new installation screens:

  • The call-to-action button is not right aligned (see attachments 1 and 2.
  • The control to show and hide all module installation summaries at once is not right aligned (see attachment 1.
  • The messages shown during the installation sometimes seem to extend beyond the area reserved for the form (see attachment 2).
  • On the license screen (see right-alignment.png):
    • The input fields do not have the same width and do not extend until the right edge of the form area.
    • The input fields should be 160px from the left edge of the form area.
  • On IE 11 and Windows 8 (see all attachments with a name starting with Windows8_IE11 such as this one):
    • There seems to be a problem with the footer area, which is shown towards the top of the page.
    • There might be a problem with the arrow design element attached to the "Messages" title.


 Comments   
Comment by Philip Mundt [ 20/Oct/16 ]

When clicking on Show all details (See ) we get an exception in the log:

SCHWERWIEGEND: Servlet.service() for servlet [default] in context with path [/magnoliaPublic] threw exception
java.lang.IllegalStateException: No resource found at /mgnl-resources/images/moduleManagerUI/favicon.ico
	at info.magnolia.module.ui.InstallationResourcesServlet.doGet(InstallationResourcesServlet.java:77)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:636)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
	at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:148)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79)
	at info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:65)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85)
	at info.magnolia.cms.filters.SafeDestroyMgnlFilterWrapper.doFilter(SafeDestroyMgnlFilterWrapper.java:107)
	at info.magnolia.cms.filters.MgnlFilterDispatcher.doDispatch(MgnlFilterDispatcher.java:67)
	at info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:108)
	at info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:94)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:108)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:620)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:349)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:784)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:802)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1410)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:745)
Comment by Maxime Michel [ 20/Oct/16 ]

Here are a few notes from my QA:

  • I tested on various browsers and when I used Chrome I understood why Federico asked if we could use AJAX to prevent the flashing. It’s pretty annoying there.
  • for maximum security, we should be using HTTPS links to Magnolia websites
  • the welcome page should be strictly the same across bundles (pro, stk, ce), not have minor indentation differences.
  • HTML from install tasks (#heading, #taskDescription) should be escaped when spit out, because it breaks the HTML (`<travel>` in demo-projects is an example). This doesn't have any visual effect, though.
  • Disabling the 'start up Magnolia' button once it’s been clicked would be nice to do while we’re at it, as multiple clicks generate DefaultQuartzScheduler-related exceptions
Generated at Mon Feb 12 04:18:10 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.