[MAGNOLIA-6861] DefaultMessageBundlesLoader might not load messages properties files correctly resulting in broken translations Created: 07/Nov/16 Updated: 18/May/17 |
|
| Status: | Accepted |
| Project: | Magnolia |
| Component/s: | i18n |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Philip Mundt | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Story Points: | 5 | ||||||||||||
| Description |
|
info.magnolia.i18nsystem.DefaultMessageBundlesLoader might read messages.properties files incorrectly, resulting in broken translations. The problem becomes visible due to another issue, where the locale of the legacy translation system is determined in another way than the new mechanism, see Here, the German translation from the lang-de module would show up in the ee-pro-demo-bundle. Key menu.security.usersPublic of travel-demo:pages/pur template (which uses legacy i18nBasename and key). In https://git.magnolia-cms.com/projects/LANG/repos/de/commits/28546be5f8469d1e02363cd2edd5d2e361e13c11#src/main/resources/mgnl-i18n/public-user-registration/app-public-user-registration-security-messages_de.properties UTF-8 encoded chars were removed and replace by proper Umlauts. Broken Umlauts now show up in the template selection dialog see Ćffentlicher Benutzer should be Ćffentlicher Benutzer. Possible sourceWhen removing the org.apache.commons.io.input.BOMInputStream (introduced in https://git.magnolia-cms.com/projects/PLATFORM/repos/main/commits/1b0de82a4a715e6fb5c8187b27dcc1d239b38e78) from info.magnolia.i18nsystem.DefaultMessageBundlesLoader#loadResourcesInPropertiesMap the translation show up correctly. Might relate to https://code.google.com/p/guava-libraries/issues/detail?id=345. |