[MAGNOLIA-6863] JCR configuration source wouldn't print the details of a registered definition Created: 07/Nov/16  Updated: 03/Oct/17

Status: Open
Project: Magnolia
Component/s: None
Affects Version/s: 5.5
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Aleksandr Pchelintcev Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-6743 Aggregate problems during Node2Bean c... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Yaml config source would print a similar line when a definition is registered:

2016-11-07 15:35:14,904 INFO agnolia.config.source.yaml.YamlConfigurationSource: Registered definition from YAML file [/layout-demos/dialogs/pages/dummy-page-properties.yaml]: [dialog] definition [dummy-page-properties] with reference id: [layout-demos:pages/dummy-page-properties] from module [layout-demos] at [pages/dummy-page-properties]

JCR config source does not (I suspect it used to do it, but can't find a commit/place). Especially in development mode the problem statistic printout becomes context-less and
doesn't mean much.
{{2016-11-07 15:35:14,536 WARN .magnolia.config.source.jcr.JcrConfigurationSource: 0 major and 1 minor problems have been encountered
2016-11-07 15:35:14,554 WARN .magnolia.config.source.jcr.JcrConfigurationSource: 0 major and 1 minor problems have been encountered
2016-11-07 15:35:14,560 WARN .magnolia.config.source.jcr.JcrConfigurationSource: 0 major and 1 minor problems have been encountered
2016-11-07 15:35:14,582 WARN .magnolia.config.source.jcr.JcrConfigurationSource: 0 major and 1 minor problems have been encountered
...}}

Solution:

  • add a similar registered definition entry to the log
  • change the problem statistic messages severity to 'debug'


 Comments   
Comment by Mikaël Geljić [ 03/Oct/17 ]

If that still holds, I ran into some related oddity:

  • JcrConfigurationSource always calls #unregisterAndRegister (like older def-managers before 5.4)
  • YamlConfigurationSource always calls #register, except for deletion where it calls #unregisterAndRegister.

Would be good to harmonize that in the magnolia-configuration module (maybe decomposing the AbstractRegistry API into register/update/unregister); then presumably the log would follow along.

Generated at Mon Feb 12 04:18:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.