[MAGNOLIA-7005] It's possible to create same name siblings (only under root node) Created: 07/Apr/17  Updated: 03/Mar/23  Resolved: 16/Dec/21

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 6.0, 6.2
Fix Version/s: 6.2.15

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Thuy To
Resolution: Fixed Votes: 1
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: 6d 7.5h
Original Estimate: Not Specified

Attachments: PNG File image-2020-04-21-07-37-29-102.png     PNG File image-2020-04-21-07-41-56-713.png     PNG File image-2021-11-30-14-32-42-007.png     PNG File image-2021-12-16-10-38-26-518.png     PNG File image-2021-12-16-10-39-27-792.png     Text File patch.patch    
Issue Links:
Problem/Incident
causes MAGNOLIA-8309 Missing "Add" actions in the "Securit... Closed
causes PAGES-470 Concurrent creation of pages/componen... Closed
Relates
relates to MAGNOLIA-6893 Move action doesn't check for possibl... Closed
relates to MAGNOLIA-8812 It's possible to import same name sib... Open
causality
is causing PAGES-424 Wrong page is marked as deleted Closed
duplicate
duplicates PAGES-151 Same name sibling created when import... Closed
duplicates MGNLUI-2717 With drag-and-drop before and after a... Closed
is duplicated by MGNLUI-6730 Importing / Exporting same item at ro... Closed
relation
is related to MGNLUI-6992 Handle an error on UI when importing ... Open
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Sprint: Global Maintenance 2, Global Maintenance 3
Story Points: 3

 Description   

MAGNOLIA-6893 fixed this problem for move actions but the same problem is there for:

  • adding node by code (Node#addNode action)
  • import (hopefully will be fixed by fixing addNode, to be checked)

MAGNOLIA-6893 already introduced a session wrapper, we just need to add a node wrapper.

This is due to a bug in jackrabbit which allows same name sibling at root even though same name siblings are disabled by repo config.



 Comments   
Comment by Thuy To [ 30/Nov/21 ]

Hi rkovarik ,

Please help me verify if i'm wrong. The same name sibling issue is occurring when importing a page on Page app. Could we disable the import button on UI to prevent the same name sibling issue instead of fixing on addNode action? 

Thanks  :bow:

Comment by Roman Kovařík [ 30/Nov/21 ]

Hey thuy.to,

that would workaround the problem only for UI, but the problem would remain for adding node/import by code.

I will check where the fix could be and update this comment with a suggested code change. patch.patch

 

Roman

 

 

Comment by Thuy To [ 30/Nov/21 ]

Thank you very much rkovarik . I'll apply and test it.  🙇‍♀️ 

Comment by Thuy To [ 10/Dec/21 ]

Hi rkovarik ,

Importing a page with the same name siblings will throw an error after this ticket is done. Do we have the follow up ticket to handle this error on UI? 

Comment by Thuy To [ 16/Dec/21 ]

For release notes: 

When importing a page with the same name siblings, it throws the error in both log and browser.

 

Created the follow-up ticket to handle this error on UI: https://jira.magnolia-cms.com/browse/MGNLUI-6992

 

Generated at Mon Feb 12 04:19:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.