[MAGNOLIA-7014] MagnoliaServletContextListener and MagnoliaInitPaths don't play well together Created: 20/Apr/17  Updated: 20/Apr/17

Status: Open
Project: Magnolia
Component/s: core
Affects Version/s: 5.5.3
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Daniel Kasmeroglu Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Testcase included:
Yes

 Description   

The MagnoliaServletContextListener gets the server name from MagnoliaInitPaths and makes it available as a server property.
The module registration happens afterwards.

This has the following side effects:

  • The values provided by MagnoliaInitPaths cannot be properly overridden as it depends on module registration when this will be available.
  • Modules cannot grant that they will access proper values in MagnoliaInitPaths as it's not sure that the module providing the override had already been started.
  • The system property server that will be set is inherently unreliable in these cases.

The issue can be checked out in the following GIT Repository:

Possible solutions:

  • Do NOT make this customizable, so the values might be provided by the web.xml itself.
  • Improve the implementation of the default DefaultMagnoliaInitPaths so it allows to use properties as a primary source for it's values.

Generated at Mon Feb 12 04:19:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.