[MAGNOLIA-7034] Fail fast when two candidates with same type encountered in CandidateParameterResolver Created: 18/May/17 Updated: 05/Jan/18 Resolved: 05/Jan/18 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.5.4 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Ilgun Ilgun | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
info.magnolia.objectfactory.CandidateParameterResolver might end up with more than one candidate of same type and therefore injection of those parameters will be messed up. Instead upon detection of a situation as such, we should be throwing exceptions to warn the user instead of doing wrong injections. For more information: https://wiki.magnolia-cms.com/display/ARCHI/2017-05-18+Architecture+meeting+notes |
| Comments |
| Comment by Antti Hietala [ 05/Jan/18 ] |
|
Closing as Won't Do. Reopen if you encounter this issue. |