[MAGNOLIA-7189] onChildNodes does not work correctly with more then one child operation Created: 02/Nov/17  Updated: 30/Sep/21  Resolved: 30/Sep/21

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 5.5.7
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Frank Sommer Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: y2k
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The onChildNodes operation iterates over the child nodes in a wrong way. Instead of doing all child operations for every node, it steps to the next node after every child operation.

https://git.magnolia-cms.com/projects/PLATFORM/repos/main/browse/magnolia-core/src/main/java/info/magnolia/jcr/nodebuilder/Ops.java#238

wrong code
while (iter.hasNext()) {
  for (NodeOperation childrenOp : childrenOps) {
    childrenOp.exec(iter.nextNode(), errorHandler);
  }
}
correct code
while (iter.hasNext()) {
  Node childNode = iter.nextNode();
  for (NodeOperation childrenOp : childrenOps) {
    childrenOp.exec(childNode, errorHandler);
  }
}


 Comments   
Comment by Marta Kobus [ 30/Sep/21 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

 

Thank you,

The Magnolia Team

Generated at Mon Feb 12 04:21:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.