[MAGNOLIA-7207] Decorations targeting non-existant definitions are reported to Definitions app Created: 28/Nov/17  Updated: 01/Feb/21  Resolved: 29/Dec/17

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 5.6.2

Type: Improvement Priority: Neutral
Reporter: Antti Hietala Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to CONTTAGS-107 Decoration of nonexistent module dam-... Open
is related to MAGNOLIA-7828 Module folder name should be compared... Accepted
is related to MGNLDAM-933 Decoration of nonexistent module dam-... Open
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: YAML backwards compatibility
Sprint: Kromeriz 124, Kromeriz 125, Kromeriz 126, Kromeriz 127, Kromeriz 128
Story Points: 8

 Description   

Confirm that all problems with YAML definitions are reported to Definitions app

  • Decorations targeting non-existant definitions.
  • -Extends targeting non-existant definitions.- no need to support JCR config
  • -Inherits targeting non-existant definitions.- already implemented

Reported messages should

  • Which tag is used (inherit, decorate)
  • Which class / definition / whatever is deprecated / not found

Please note Magnolia's behaviour in those cases currently as a comment or in a wiki page.

Requirement in YAML backwards compatibility



 Comments   
Comment by Evzen Fochr [ 02/Dec/17 ]
  • Decorations targeting non-existant definitions.
    • incorrect filename (component name) in decoration folder do not cause any error - no error in definition app
  • Extends targeting non-existant definitions.
    • Extending non-existant definition cause only error in console like:
      2017-12-02 18:24:40,125 ERROR info.magnolia.jcr.wrapper.ExtendingNodeWrapper : Can't find referenced node for value: node /modules/tours/templates/components/catCloud - no error in definition app
  • Inherits targeting non-existant definitions. - correctly reported
    • referenced components in availableComponents are not checked for existence - no error in definition app
  • Definitions which reference definitions which do not exist.(For example a template definition references a non-existent dialog definition)
    • referenced dialog is not checked for existence - no error in definition app
    • tackled by MAGNOLIA-7217
Generated at Mon Feb 12 04:21:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.