[MAGNOLIA-7230] Incorrect task order of MigrateVersionWorkspacesToNewStructureTask Created: 02/Jan/18  Updated: 04/Jan/18

Status: Open
Project: Magnolia
Component/s: installation
Affects Version/s: 5.5.6, 5.5.7, 5.5.8, 5.6, 5.6.1
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Le Hai Thanh Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-7006 same name siblings issue in MigrateVe... Closed
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

During Weblaw migration, we got an issue Task 'Migrate version workspace' failed caused by The move operation was not completed due to an item with the same name already present. The issue was fixed by https://jira.magnolia-cms.com/browse/MAGNOLIA-7006.

It seems to me that there is a wrong task order as the MigrateVersionWorkspacesToNewStructureTask (5.5.0) was run BEFORE the RenameVersionNodesTask (5.5.4).

But the MigrateVersionWorkspacesToNewStructureTask should run AFTER the RenameVersionNodesTask

CoreModuleVersionHandler class

register(DeltaBuilder.update("5.5", "")
                .addTask(new MigrateVersionWorkspacesToNewStructureTask(repositoryManager))
                .addTasks(getLockableMixinAdditionTasksForAllWorkspaces())
                .addTask(new NodeExistsDelegateTask("Add korean language into system languages", "/server/i18n/system/ko", null,
                        new BootstrapSingleModuleResource("", "", "config.server.i18n.system.xml", "/system/languages/ko")))
        );

        register(DeltaBuilder.update("5.5.4", "")
                .addTask(new BootstrapSingleModuleResource("Add mime mapping for YAML", "Add mime mapping for YAML", "config.server.MIMEMapping.xml", "/MIMEMapping/x-yaml"))
                .addTask(new RenameVersionNodesTask(repositoryManager))
        );

Generated at Mon Feb 12 04:21:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.