[MAGNOLIA-7258] ModelExecutionFilter should stop rendering if response is committed Created: 08/Feb/18  Updated: 08/Feb/18

Status: Open
Project: Magnolia
Component/s: rendering
Affects Version/s: 5.6.1
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Marcus Büttner Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

ModelExecutionFilter continues rendering after models executeEarly although the response is committed already (e.g. Response#sendRedirect).

In ModelExecutionFilter#handleExecutionResult there is a comment to describe this behavior but the return value should be true instead of false.

 // If the model rendered something on its own or sent a redirect we will not proceed with rendering.
        if (response.isCommitted()) {
            return false;
        }

Generated at Mon Feb 12 04:22:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.