[MAGNOLIA-7297] When selector is present in URL, dots in file name are treated as file extensions Created: 09/Apr/18  Updated: 18/May/18  Resolved: 15/May/18

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 5.5.11, 5.6.6

Type: Bug Priority: Neutral
Reporter: James Spence Assignee: Antonín Juran
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Support
Sprint: Kromeriz 144, Kromeriz 145, Kromeriz 146, Kromeriz 147
Story Points: 13

 Description   

Assume we have a URL like /path/to/my/cool-page-1.12.html.

 

When requested normally, the URL resolves properly.

However, if we instead request /path/to/my/cool-page-1.12~foo=bar~.html, the URL does not resolve properly.

 

This is due to the RepositoryMappingFilter and its handling of selectors. The filter strips out selectors and everything after the filter (including the file extension). It then passes the path (minus selector and extension) to a URI2RepositoryMapping. That mapping treats the .12 as a file extension, and incorrectly strips it out.

 

EDIT: New PR here - https://git.magnolia-cms.com/projects/PLATFORM/repos/main/pull-requests/598/overview



 Comments   
Comment by James Spence [ 04/May/18 ]

Hi all, just to ensure it is visible - we actually created a PR that addresses this issue here: https://git.magnolia-cms.com/projects/PLATFORM/repos/main/pull-requests/598/overview

 

Are these changes being considered or pulled in at all? I see activity on this ticket and want to ensure that our PR wasn't overlooked  thank you!

Generated at Mon Feb 12 04:22:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.