[MAGNOLIA-7318] DialogDefinitionValidator should handle deprecation cases correctly Created: 14/May/18 Updated: 18/May/18 |
|
| Status: | Accepted |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.6.5 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Ilgun Ilgun | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Epic Link: | LD: Simple dialog config | ||||||||
| Story Points: | 3 | ||||||||
| Description |
|
Currently info.magnolia.ui.dialog.registry.validator.DialogDefinitionValidator only check if the given definition class has a deprecated field type definition and if yes it reports it. That behaviour will become incorrect in the next release, however, as with the next release we have made changes in FieldFactoryFactory that deprecated field types will be not selected if there is non-deprecated one present. That means for the validator that current logic of reporting any deprecation will cause false positives in the definitions app. info.magnolia.ui.dialog.registry.validator.DialogDefinitionValidator should be checking if the given definition class have deprecated field types, if yes it should also check if there is one non-deprecated one, if yes it shouldn't report anything because FieldFactoryFactory will simply use that. Same goes for the decoration. For more information have a look at |