[MAGNOLIA-7334] Make LazyNodeWrapper prefer JCR session from user context to the one from system context Created: 05/Jun/18 Updated: 11/Jun/18 Resolved: 08/Jun/18 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.6.5 |
| Fix Version/s: | 5.6.6, 5.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Epic Link: | UI framework implementation |
| Sprint: | Basel 148, Basel 149 |
| Story Points: | 2 |
| Description |
|
LazyNodeWrapper is capable of re-attaching the underlying node in case its session got closed. However, with current logic the node is re-attached to the session from the system context and not to the user's one, which confusing and error prone. Proposal: try to re-attach the node to the session from the MgnlContext, use system context as a fallback. This is issue is particularly important for the UI framework improvement effort which encourages the developers to use the nodes directly in the app implementation and LazyNodeWrapper is a handy tool for keeping node alive across requests and is expected to act predictably. |