[MAGNOLIA-7435] Performance: incorrect decoration of info.magnolia.rendering.renderer.AbstractRenderer#render Created: 25/Dec/18 Updated: 31/Aug/21 Resolved: 31/Aug/21 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.7.1, 6.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Viet Nguyen | Assignee: | Unassigned |
| Resolution: | Outdated | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Description |
|
The info.magnolia.rendering.renderer.FreemarkerRenderer#render is being wrongly decorated by info.magnolia.config.source.DefinitionProviderWrapperWithProxyFallback. The "render" method in AbstractRenderer has a void return type so the condition at line 84 in DefinitionProviderWrapperWithProxyFallback ( if (result == null) { ) will always be true resulting in unnecessary invocation attempt that throws an exception because the arguments are not passed at line 86 (return method.invoke(fallbackDefinition) |