[MAGNOLIA-7478] DOC: locale aware virtualUriMapping Created: 12/Mar/19  Updated: 07/Dec/21  Resolved: 07/Dec/21

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Roman Kovařík Assignee: Martin Drápela
Resolution: Done Votes: 0
Labels: maintenance
Remaining Estimate: 5h
Time Spent: 2h 16m
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Relates
relates to MGNLDEMO-66 Tour page only displays english Closed
relates to MAGNOLIA-6851 Enabled i18n breaks Virtual URI Mappi... Accepted
relates to MGNLDEMO-386 Exceptions on homepage when switching... Closed
relates to MGNLDEMO-324 Internationalisation with SiteMesh Closed
causality
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Installation without travel demo:

  1. request for /de/source
  2. i18n filter detects language DE and strips language prefix: /source
  3. virtualUriFilter forwards to /target (default locale)
  4. i18n filter detect default (wrong) language

Installation with travel demo (has bypass configured on i18n filter for fowards):

  1. request for /de/source
  2. i18n filter detects language DE and strips language prefix: /source
  3. virtualUriFilter forwards to /target (default locale)
  4. i18n is bypassed (keeping the correct language in the context)

Forwards are working but dynamic fragments are broken as those include the language prefix.

The bypass should be either

  • configured by default (not only by travel demo) and dynamic fragments should be requested without the locale prefix (this seems to be the most straightforward solution) or
  • no bypass, i18n would be triggered for forwards
    • virtualUriFilter would have to be before the i18n filter (this would change the order of the cache filter as well!)
      • forward have to be configured including the language prefix (/ {locale}/source) -> /{locale}

        /target)

We have integration tests for personalisation but the language specific request are probably not covered.



 Comments   
Comment by Roman Kovařík [ 12/Mar/19 ]

To workaround the issue with dynamic fragments, remove the bypass on i18n filter for forwards and add bypasses for your language aware virtual URI mapping forwards instead.

Comment by Roman Kovařík [ 22/Oct/21 ]

The issue was caused by bypass in i18n filter installed by demo (or manually by customers).

This will be/is addressed by MGNLDEMO-386.

Therefore closing this ticket.

Comment by Roman Kovařík [ 09/Nov/21 ]

Reopening and converting into docu ticket:
Document couple options to handle virtual URI mapping with/without language prefix

  • A] bypass on forward (6.2.12 demo solution), can be used only without sitemesh module (or without cp13n/DPC)
  • B] 6.2.13 solution for demo (changed order or filters but redirects are not cached)
  • C] keep 6.2.12 order of filters (if tours like mapping is not used in project or you don't have language variation for these)
Generated at Mon Feb 12 04:24:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.