[MAGNOLIA-7559] Support whitelisting for AnnotationProcessingTypeResolver Created: 19/Jun/19  Updated: 21/Jun/19  Resolved: 19/Jun/19

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1

Type: Improvement Priority: Critical
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-7469 Annotation processing type resolver i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Sprint: 6.1 Release Sprint
Story Points: 2

 Description   

AnnotationProcessingTypeResolver should support whitelisting.

 

This will also help with problem on WAS, WLP, WLS, WildFly where types are not resolved - https://git.magnolia-cms.com/snippets/fd1584fba03249b3aac256e853855349

Problem on WAS, WLP, WLS, WildFly is in org.reflections.util.ClasspathHelper#forClassLoader method which is used when org.reflections.Reflections is not limited to certain package(s). This method loads resources only from classloaders which are instance of URLClassLoader, but that is not case for WAS, WLP, WLS, WildFly. 

If org.reflections.Reflections is limited to certain package(s) then org.reflections.util.ClasspathHelperforResource#forResource method is used which loads resources from whatever classloader.



 Comments   
Comment by Dai Ha [ 20/Jun/19 ]

QA done for wildfly, using magnolia-dx-core-wildfly-webapp-6.1-20190619.161112-72.war.

Generated at Mon Feb 12 04:24:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.