[MAGNOLIA-7873] LockException when restoring version of a page Created: 10/Sep/20  Updated: 13/Dec/21  Resolved: 13/Dec/21

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 6.2.12
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Michael Duerig Assignee: Christoph Meier
Resolution: Obsolete Votes: 0
Labels: QA&Testing, artt, tech-debt, to-verify
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File restoreVersion.log    
Issue Links:
Problem/Incident
causes MGNLTEST-90 Consolidate framework for PagesCoreFu... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Intermittently restoring a previous version of a page fails with a LockException. This causes failures of PagesCoreFunctionalTests#restoreVersion:

Caused by: javax.jcr.lock.LockException: Node locked.
at org.apache.jackrabbit.core.lock.LockManagerImpl.checkLock(LockManagerImpl.java:694) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.lock.LockManagerImpl.checkLock(LockManagerImpl.java:670) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.lock.XALockManager.checkLock(XALockManager.java:188) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.BatchedItemOperations.verifyUnlocked(BatchedItemOperations.java:1406) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.BatchedItemOperations.checkAddNode(BatchedItemOperations.java:669) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.BatchedItemOperations.copy(BatchedItemOperations.java:398) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.WorkspaceImpl.internalCopy(WorkspaceImpl.java:430) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at org.apache.jackrabbit.core.WorkspaceImpl.clone(WorkspaceImpl.java:636) ~[jackrabbit-core-2.20.0.jar:2.20.0]
at info.magnolia.jcr.wrapper.DelegateWorkspaceWrapper.clone(DelegateWorkspaceWrapper.java:114) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.jcr.wrapper.DelegateWorkspaceWrapper.clone(DelegateWorkspaceWrapper.java:114) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.jcr.wrapper.DelegateWorkspaceWrapper.clone(DelegateWorkspaceWrapper.java:114) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.jcr.wrapper.MgnlPropertySettingContentDecorator$MgnlPropertySettingWorkspaceWrapper.clone(MgnlPropertySettingContentDecorator.java:488) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.jcr.wrapper.DelegateWorkspaceWrapper.clone(DelegateWorkspaceWrapper.java:114) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.jcr.wrapper.DelegateWorkspaceWrapper.clone(DelegateWorkspaceWrapper.java:114) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.CopyUtil.clone(CopyUtil.java:309) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.CopyUtil.clone(CopyUtil.java:277) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.CopyUtil.copyAllChildNodes(CopyUtil.java:261) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.CopyUtil.copyFromVersion(CopyUtil.java:195) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.BaseVersionManager$2.exec(BaseVersionManager.java:492) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.BaseVersionManager$2.exec(BaseVersionManager.java:463) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.security.JCRSessionOp.exec(JCRSessionOp.java:68) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:378) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:356) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.cms.core.version.BaseVersionManager.restore(BaseVersionManager.java:463) ~[magnolia-core-6.2.3.jar:?]
at info.magnolia.ui.contentapp.action.RestoreJcrVersionAction.execute(RestoreJcrVersionAction.java:75) ~[magnolia-ui-framework-jcr-6.2.3.jar:?]

Full logs attached: restoreVersion.log

Dev notes

Still reproducible with 6.2.12-SNAPSHOT



 Comments   
Comment by Maxime Michel [ 13/Sep/21 ]

Still an issue as of today, says fgrilli.

Comment by Christoph Meier [ 13/Dec/21 ]

We think that this issue has been resolved by the latest update of jackrabbit.

When this ticket had been created - the test PagesCoreFunctionalTests#restoreVersion was disabled, because it was failing constantly.
Now, while working on MGNLCE-187 - PagesCoreFunctionalTests#restoreVersion has been re-enabled and tests were run with repetitions - and test passed successfully almost always.

So - closing this one now - since it is obsolete now.
And the test now re-enabled and merged to master

 

Generated at Mon Feb 12 04:27:36 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.