[MAGNOLIA-8006] Multiple !include file support Created: 19/Feb/21 Updated: 09/Mar/22 Resolved: 30/Jul/21 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 6.2.6 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Richard Gange | Assignee: | Unassigned |
| Resolution: | Obsolete | Votes: | 7 |
| Labels: | light-development | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Release notes required: |
Yes
|
||||||||||||
| Documentation update required: |
Yes
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
Add the ability to specify multiple include files within curly brackets
form:
properties:
!include:{
/mtk/includes/dialogs/page-main.yaml,
/mtk/includes/dialogs/page-meta.yaml
}
|
| Comments |
| Comment by Ueli Scheidegger [ 22/Jun/21 ] |
|
Several of our EE-customers are affected by this issue. Should they create separate tickets? |
| Comment by Mercedes Iruela [ 22/Jun/21 ] |
|
Please, create just one support ticket with some example/s of the specific issue and add the list of affected customers there. Thanks |
| Comment by Richard Gange [ 30/Jul/21 ] |
|
Closing this since we brought back the old tabbed layout configuration with |
| Comment by Ueli Scheidegger [ 09/Mar/22 ] |
|
Hey Richard I'm afraid I do not quite understand the connection between
form:
name: Page properties
properties:
- !include:/path/to/oneProperty.yaml
- !include:/path/to/anotherProperty.yaml
This worked fine in Magnolia 5.7 but fails on me in Magnolia 6.2. In fact, the Migration Tool is replacing the includes by the target code. This of course is not very helpful. Do you have any advice on how to resolve this, since you closed this issue? Thanks! |
| Comment by Richard Gange [ 09/Mar/22 ] |
|
Hello Ueli- The reason it became obsolete is because if you have the ability to use the old tabbed layout then you should have the ability to use include like it was before. So my example in the description is about including tabs (main and meta). In Magnolia 6 we decoupled the layout from the property definitions. Prior to that, with tabs, the two were a combined configuration. Which is now again possible since I cannot speak for how the Migration tools works or you specific use case but if you'd like to discuss it further than please open a support ticket. Regards |
| Comment by Ueli Scheidegger [ 09/Mar/22 ] |
|
Ah, now I think I get it. Thanks. We're transforming the dialogs to `$type: tabbedForm` now and this in fact does seem to do the trick... although it also makes the Migration Tools even less valuable than before. |