[MAGNOLIA-8036] Allow decoration of light modules whose name contains dots Created: 19/Mar/21 Updated: 18/Aug/21 |
|
| Status: | Accepted |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.7, 6.1, 6.2 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Federico Grilli | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | maintenance, quickwin | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Patch included: |
Yes
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Documentation update required: |
Yes
|
||||||||
| Story Points: | 1 | ||||||||
| Description |
|
A light module whose name contains dots, e.g. foo-bar-6.2 does not get its decoration applied in spite of dot being a valid character for folder names in all major operating systems. Our documentation actually mentions that some special characters should be avoided when creating light modules but perhaps with dot we could be more forgiving? I was puzzled at first as to why my decorations were not picked up and took me some debugging to figure out the reason - afraid some customers could stumble into the same troubles. PR is provided. |