[MAGNOLIA-8255] QueryTask warning might be more subtle Created: 15/Dec/21  Updated: 15/Dec/21

Status: Open
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by MAGNOLIA-5857 Provide a NodeVisitorTask and emphasi... Closed
causality
is causing MGNLPN-535 Task 'Change structure of mgnl:person... Closed
is causing MGNLPN-536 Task 'Change structure of mgnl:segmen... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

Steps to reproduce

  1.  Use a QueryTask in a version handler
  2.  Update an instance

Expected results

If I know the content I want to update a content that shouldn't be updated in the same Magnolia version update, I should be able to use the QueryTask without a warning (at least on the installation screen).

Actual results

QueryTask produces a warning introduced by MAGNOLIA-5857, making developers use
NodeVisitorTask which in turn introduces performance issues (especially because info.magnolia.module.delta.NodeVisitorTask#getFilteringPredicate doesn't filter out any nodes, making the tasks iterate on all system nodes), see linked tickets.

Workaround

Use the QueryTask despite the warning.

Development notes

The warning was quite useful at the time it was introduced as we had huge amount of updates, often depending on changes in the same session. Nowadays are the update tasks rare especially due to do config in YAML and often developing only using light modules.


Generated at Mon Feb 12 04:31:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.