[MAGNOLIA-8260] Resolve inconsistent API behaviour wrt dangling Definition Decorators Created: 17/Dec/21  Updated: 27/Dec/21

Status: In Progress
Project: Magnolia
Component/s: None
Affects Version/s: 6.3.0
Fix Version/s: 6.3.0

Type: Task Priority: Neutral
Reporter: Rishab Dhar Assignee: Mikaël Geljić
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: SaaS ITs
Sprint: SaaS 23, Global Maintenance 3
Story Points: 0

 Description   

Background

Currently the DecorationConfigurationSource aggregates the decorations that do not have a corresponding definition provider available into a map of danglingDecorators.

However, there is a consistency between the APIs exposed:

  • getAllProviders() and getAllMetadata() aggregate not only the definition providers from different configuration sources but also include the dangling definition decorators.
  • Meanwhile getProvider(...) API searches for the requested DefinitionProvider only in the underlying ConfigurationSources

This inconsistent behaviour bubbles up higher in the API chain, due to NoSuchDefinitionException leading to End of the World behaviour in the exposed REST APIs.


Generated at Mon Feb 12 04:31:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.