[MAGNOLIA-8286] As a developer, I can add a servlet via annotation or web.xml Created: 21/Jan/22 Updated: 10/May/22 Resolved: 31/Mar/22 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0 |
| Type: | Story | Priority: | Neutral |
| Reporter: | David Lopez | Assignee: | Fernando Cherchi |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | nucleus | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Epic Link: | Externalize user sensitive configuration | ||||||||||||||||||||||||
| Sprint: | Nucleus 4, Nucleus 5, Nucleus 6, Nucleus 7 | ||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||
| Team: | |||||||||||||||||||||||||
| Description |
ProblemMagnolia currently doesn't support proper servlet registration. Servlets are wrapped in filter chain as servlet. As consequence, developers can't easily register servlet in a standard way (annotation or web.xml). Expected resultsI can register servlets in a standard way. I can override the servlet configuration (e.g. metadata-complete=false in web.xml and define explicitly in web.xml) Actual resultsRequests are terminated (404) before reaching the servlet. WorkaroundCofigure a bypass in CMS filter so requests are not terminated before reaching the servlet. Development notesTermination can be prevent e.g. by introducing a default bypass voter on CMS filters which skips servlet requests (ServletContext#getServletRegistrations). |
| Comments |
| Comment by Roman Kovařík [ 22/Mar/22 ] |
|
agomez QA steps (for
(be aware that you wouldn't be able to access the admincentral if something goes wrong) |
| Comment by Roman Kovařík [ 23/Mar/22 ] |
|
Reopened: see the suggestion on the PR. |