[MAGNOLIA-8311] Replacement for I18nAuthoringSupport#createI18NURI Created: 18/Feb/22  Updated: 19/Jul/22  Resolved: 15/Mar/22

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.18

Type: Story Priority: Neutral
Reporter: Roman Kovařík Assignee: Jaromir Sarf
Resolution: Done Votes: 0
Labels: VN-Testing, nucleus
Remaining Estimate: Not Specified
Time Spent: 3.5h
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLSITE-110 Adjust SiteI18nContentSupport to new ... Closed
dependency
is depended upon by PAGES-563 Page editor status uses deprecated me... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Epic Link: Nucleus Regular Maintenance
Sprint: Nucleus 5
Story Points: 3
Team: Nucleus

 Description   

This method I18nAuthoringSupport#createI18NURI is deprecated since 6.0 and was removed in 6.2.x

Problem

The method uses a hack (setting/resetting locale value) to create an I18n URI.

Proposed solution.

Expose AbstractI18nContentSupport#toI18NURI(String, Locale).

Consequences

A binary incompatibility by changing protected to public modifiers affecting classes extended from AbstractI18nContentSupport.

Usages

https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-pages-app/src/main/java/info/magnolia/pages/app/detail/PageEditorStatus.java#197
formally removed within PAGES-563 (copy&paste of logic)
 



 Comments   
Comment by Roman Kovařík [ 24/Feb/22 ]

Discovery: see the PoC on branch

Comment by Roman Kovařík [ 10/Mar/22 ]

For release notes:

This method is introducing this binary incompatibility:

A binary incompatibility by changing protected to public modifier of AbstractI18nContentSupport#toI18NURI(String, Locale).

What is affected:

  • custom classes extended from {{AbstractI18nContentSupport }}
  • AND also overriding the affected method.

How to fix:

  • change the protected to public modifier 

 

 

Generated at Mon Feb 12 04:31:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.