[MAGNOLIA-8346] Findbar creates the SearchExecutor through a dubious contruction. Created: 14/Mar/22 Updated: 10/Jan/24 Resolved: 21/Nov/23 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Rico Jansen | Assignee: | Quach Hao Thien |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | dx-core-6.3 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Epic Link: | Build on Java 17 |
| Work Started: | |
| Approved: |
Yes
|
| Description |
|
info.magnolia.admincentral.findbar.FindBar creates info.magnolia.admincentral.findbar.search.SearchExecutor by the following line: this.searchExecutor = componentProvider.newInstance(SearchExecutor.class, updateResultsOperation); This is dubious as the constructor of SearchExecutor is package protected and SearchExecutor lives in a different package. If one would get involved with JigSaw this will probably break.
|
| Comments |
| Comment by Mikaël Geljić [ 21/Nov/23 ] |
|
public keyword was most likely omitted upon creation of this class, fixed now |